Re: [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[Andy Shevchenko]

On Wed, Jul 08, 2026 at 10:01:50AM +0200, Joshua Crofts wrote:
> On Wed, 8 Jul 2026 10:47:48 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> 
> > On Wed, Jul 08, 2026 at 07:34:11AM +0200, Joshua Crofts wrote:
> > > This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
> > > AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
> > > may result in a failure.  
> > 
> > > Steps to reproduce build failure:
> > > 1. Run `make allnoconfig`.
> > > 2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
> > > 3. Run `make .` and make will end with regmap-related errors.  
> > 
> > Repeating same mistake from the previous similar contribution. Where is the
> > actual excerpt of the failure? Please, provide one.
> > 
> 
> Here is one of the several errors when compiling.
> 
> drivers/iio/adc/max14001.c: In function ‘max14001_probe’:
> drivers/iio/adc/max14001.c:315:22: error: implicit declaration of function ‘devm_regmap_init’ [-Wimplicit-function-declaration]
>   315 |         st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
>       |                      ^~~~~~~~~~~~~~~~
> drivers/iio/adc/max14001.c:315:20: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   315 |         st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
>       |                    ^
> 
> Funny how I essentially copied the cover letter from the series where I added
> missing IIO_TRIGGER_BUFFER entries to Kconfig - to which you didn't require
> an example build error :-)
> 
> Shall I do a v2 or is this reply enough?

For now this reply is enough, but in the future add it to the initial
contribution from the start.

-- 
With Best Regards,
Andy Shevchenko