Re: [PATCH v1] clang-format: Fix formatting of guard()
From: Mickaël Salaün
Date: Wed Jul 08 2026 - 07:12:09 EST
On Wed, Jul 08, 2026 at 01:06:12PM +0200, Miguel Ojeda wrote:
> On Wed, Jul 8, 2026 at 12:57 PM Mickaël Salaün <mic@xxxxxxxxxxx> wrote:
> >
> > The previous fix was overzealous and included guard() along with
> > scoped_guard(), but only the later takes curly braces.
> >
> > The original fix introduced this issue:
> > - guard(rcu)();
> > + guard(rcu)
> > + ();
> >
> > This is especially visible with security/landlock/*.[ch] which is fully
> > formatted with clang-format.
>
> This one would go away on its own if one runs the command above from
> where the list is meant to be generated -- but `scoped_guard()` would
> be also removed.
What do you mean? Running clang-format -i security/landlock/*.[ch] does
some changes.
>
> I guess I can just have a section of explicit ones that come from
> outside the line.
>
> I can pick this one through `clang-format` and take the chance to give
> an update to the list.
Yes please.
>
> Thanks!
>
> Cheers,
> Miguel