Re: [PATCH v2] ALSA: control: preserve snd_card_file_add() error code in snd_ctl_open()

[Bui Duc Phuc]

Hi Cezary,

Thanks for the tip, appreciate it.

> BTW, as you've provided a number of positive contributions, a tip for
> future:
>
> The change is simple and does not relate to any workaround or some kind
> of 'recommended' sequence.  And thus there's no need to be as verbose.
> IMHO the first paragraph suffices - explicitly answers the _why_ question.
>
> The last is completely redundant - return code is a functional change.
> Similarly, "Fix this by (...)" in context of such a simple change yields
> no value for the reader - we see _what_ is happening clearly in the code.

Will keep future commit messages more concise and focused on the why.

Best regards,
Phuc