Re: [PATCH v3 1/4] mm: avoid unnecessary lru drain for wp_can_reuse_anon_folio()

From: Barry Song (Xiaomi)

Date: Wed Jul 08 2026 - 11:30:52 EST


On Tue, Jul 7, 2026 at 11:58 PM David Hildenbrand (Arm) <david@xxxxxxxxxx> wrote:
>
> On 7/7/26 17:26, Kairui Song wrote:
> > On Mon, Jul 6, 2026 at 4:54 PM Barry Song <baohua@xxxxxxxxxx> wrote:
> >>
> >> On Thu, Jul 2, 2026 at 4:05 PM David Hildenbrand (Arm) <david@xxxxxxxxxx> wrote:
> >>>
> >>> The other folks should probably re-review this patch that changed quite a bit :)
> >>>
> >>>
> >>> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
> >>
> >> Thanks!
> >>
> >> Hi Baoquan, Shakeel, and Kairui,
> >>
> >> Would you like to re-review the patches so I can re-collect your
> >> tags? If not, are you okay with me removing your tags when I
> >> send v4?
> >
> > Sure, no problem.
> >
> > The only complain from me, and a trivial one is that `in_lru_cache =
> > !folio_test_lru(folio)` looks a bit odd.
>
> I was debating with myself a bit, how to keep it short yet expressive.
>
> "maybe_in_lru_cache" could work.

yes. sounds very good to me. Thanks, Kairui and David.

Hi Andrew,

Would you like to squash the below change?