Re: [PATCH v2 0/4] fs/pipe: unify the page pools into a single per-pipe pool

From: Breno Leitao

Date: Wed Jul 08 2026 - 12:17:35 EST


On Wed, Jul 08, 2026 at 05:24:47PM +0200, Mateusz Guzik wrote:
> On Wed, Jul 8, 2026 at 5:11 PM Breno Leitao <leitao@xxxxxxxxxx> wrote:
> > That said, your approach is better than what I had, and I would like to
> > integrate it to this patch set. Os it OK if I give a Co-developed-with:
> > tag?
>
> imo this is too trivial compared to the entirety of the patchset to
> warrant attribution. Just take it.
>
> To be clear, I just now verified avoidance of the extra trip resolved
> the regression for me so I have no objections to the patchset.
>
> For completeness I note I failed to remove the lock acquire in
> anon_pipe_trim_pool_and_unlock, but I presume you noticed (at worst
> while testing).

yes, otherwise it was self deadlocking it self in AA scenario.

> One suggestion I have is to post the entire thing as one patch as I
> don't think the split here buys anything, but I'm not going to insist
> one way or the other.

Ack, I splitted the changes hoping it would make the review easier.

So, I will respin this with your suggestion in a single patch, after
some bake time (probably tomorrow).