Re: [PATCH v2 2/2] iio: dac: dac8163: Add driver for DAC8163

[Jonathan Cameron]

> > +
> > +#include <linux/array_size.h>
> > +#include <linux/bitfield.h>
> > +#include <linux/bits.h>
> > +#include <linux/err.h>
> > +#include <linux/errno.h>
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/mod_devicetable.h>  
> I asked you to add this "mod_devicetable.h" header previously. But I noticed some reviews by Uwe 
> to use more specific headers. 
> In your case these should be 
> 
> 
> #include <linux/device-id/spi.h>
> #include <linux/device-id/of.h>
> 
Not necessary given they are guaranteed to be include by the bus headers.

Take a look at what Uwe did in his series.  The actual device-id headers
are added to very few drivers - mostly the bus ones are enough.

Jonathan