Re: [RFC PATCH] ASoC: qcom: q6apm-lpass-dais: start the graph at prepare
From: Srinivas Kandagatla
Date: Wed Jul 08 2026 - 18:19:37 EST
On 7/8/26 10:55 PM, Jorijn van der Graaf wrote:
>
> So for v2 I would keep the two behaviours apart per interface type:
This is not going to scale, please try to enable the required clocks
from machine driver. Pl take a look at this series
https://lore.kernel.org/linux-sound/20260706132009.1496321-1-mohammad.rafi.shaik@xxxxxxxxxxxxxxxx/
--srini
> start the graph at the end of prepare only for the MI2S DAIs
> (q6i2s_ops), where an external codec like aw88261 needs the bit clock
> running before the DAPM power-up sequence and where q6afe has always
> started the port at prepare. b54a38af7138's other point - that there is
> no data transfer yet at prepare - still holds there, but for these
> interfaces the early start is about the clocking, not the data. The
> trigger-time start stays unchanged for the DP/HDMI DAIs (q6hdmi_ops,
> where the prepare-time start is exactly what broke) and the codec DMA
> DAIs (q6dma_ops - codecs clocked from the LPASS macros or SoundWire,
> not from the port). That also supersedes my note under the fold about
> dropping the trigger callback in a respin: it stays, as the only start
> path for the DP/HDMI and codec DMA DAIs.