Re: [PATCH] ASoC: xtensa: Use dev_err_probe() and drop redundant error handling

From: Bui Duc Phuc

Date: Wed Jul 08 2026 - 19:00:39 EST


Hi Mark,

Thank you for your review.

> > + if (IS_ERR(i2s->regmap))
> > + dev_err_probe(&pdev->dev, PTR_ERR(i2s->regmap), "regmap init failed\n");
>
> This isn't returning the error directly, it's ignoring it...

Sorry, I accidentally left out the return before dev_err_probe().
I'll fix it and send a v2 shortly.

Best regards,
Phuc