[PATCH 23/43] power: supply: max8903_charger: Remove redundant dev_err()/dev_err_probe()
From: Pan Chuang
Date: Wed Jul 08 2026 - 23:38:44 EST
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/power/supply/max8903_charger.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
index 45fbaad6c647..47334bfc8381 100644
--- a/drivers/power/supply/max8903_charger.c
+++ b/drivers/power/supply/max8903_charger.c
@@ -364,11 +364,8 @@ static int max8903_probe(struct platform_device *pdev)
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"MAX8903 DC IN", data);
- if (ret) {
- dev_err(dev, "Cannot request irq %d for DC (%d)\n",
- gpiod_to_irq(data->dok), ret);
+ if (ret)
return ret;
- }
}
if (data->uok) {
@@ -377,11 +374,8 @@ static int max8903_probe(struct platform_device *pdev)
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"MAX8903 USB IN", data);
- if (ret) {
- dev_err(dev, "Cannot request irq %d for USB (%d)\n",
- gpiod_to_irq(data->uok), ret);
+ if (ret)
return ret;
- }
}
if (data->flt) {
@@ -390,11 +384,8 @@ static int max8903_probe(struct platform_device *pdev)
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"MAX8903 Fault", data);
- if (ret) {
- dev_err(dev, "Cannot request irq %d for Fault (%d)\n",
- gpiod_to_irq(data->flt), ret);
+ if (ret)
return ret;
- }
}
return 0;
--
2.34.1