Re: [PATCH 2/2] drm/imx: include dc-drv.h to avoid sparse warning

From: Liu Ying

Date: Thu Jul 09 2026 - 02:37:41 EST


On Wed, Jul 08, 2026 at 11:56:45AM +0200, Jiri Slaby (SUSE) wrote:
> sparse (build with C=1) warns:
> drivers/gpu/drm/imx/dc/dc-ic.c:273:24: warning: symbol 'dc_ic_driver' was not declared. Should it be static?
>
> And it is right. Include dc-drv.h which declares the struct. This
> ensures the types of both match.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Cc: Liu Ying <victor.liu@xxxxxxx>
> ---
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxxx>
> Cc: Simona Vetter <simona@xxxxxxxx>
> Cc: Frank Li <Frank.Li@xxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: imx@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> drivers/gpu/drm/imx/dc/dc-ic.c | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Liu Ying <victor.liu@xxxxxxx>

Thanks.