Re: [PATCH 2/3] powerpc/boot: Fix treeboot-currituck CPU node lookup check

[IBM]

Thorsten Blum <thorsten.blum@xxxxxxxxx> writes:

> fdt_node_offset_by_prop_value() returns a negative error code on
> failure - fix the check accordingly.
>
> Fixes: 228d55053397 ("powerpc/47x: Add support for the new IBM currituck platform")
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Looks good to me. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>


> ---
>  arch/powerpc/boot/treeboot-currituck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/boot/treeboot-currituck.c b/arch/powerpc/boot/treeboot-currituck.c
> index d53e8a592f81..5b5363b74f9f 100644
> --- a/arch/powerpc/boot/treeboot-currituck.c
> +++ b/arch/powerpc/boot/treeboot-currituck.c
> @@ -102,7 +102,7 @@ void platform_init(void)
>  
>  	node = fdt_node_offset_by_prop_value(_dtb_start, -1, "device_type",
>  	                                     "cpu", sizeof("cpu"));
> -	if (!node)
> +	if (node < 0)
>  		fatal("Cannot find cpu node\n");
>  	timebase = fdt_getprop(_dtb_start, node, "timebase-frequency", &size);
>  	if (timebase && (size == 4))