Re: [PATCH 0/2] module: Remove unnecessary module::args

[Petr Pavlu]

On 6/4/26 1:04 PM, Petr Pavlu wrote:
> Historically, various parameter-handling code kept pointers into
> module::args, most notably the charp support. However, in 2009,
> commit e180a6b7759a ("param: fix charp parameters set via sysfs") changed
> charp parameters to kstrdup() the input string as well. As a result,
> module::args now mostly wastes memory.
> 
> Reviewing all kernel_param_ops and module_param_call instances shows that
> the last code still relying on module::args remaining valid for the
> module's lifetime is simdisk_param_ops_filename. Update it to use kstrdup()
> and then remove module::args.
> 
> Petr Pavlu (2):
>   xtensa/simdisk: Avoid referring to module::args
>   module: Remove unnecessary module::args
> 
>  arch/xtensa/platforms/iss/simdisk.c | 38 +++++++++++++++++++++++++----
>  include/linux/module.h              |  4 ---
>  kernel/module/main.c                | 15 ++++++------
>  3 files changed, 41 insertions(+), 16 deletions(-)
> 
> 
> base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8

Thanks Max and Aaron for the review. Queued now on modules-next for
v7.3-rc1.

-- Petr