Re: [PATCH] ALSA: oss: Drop redundant nonseekable_open() return check

Next message: Mike Rapoport (Microsoft): "[PATCH v2 1/3] mm: split out mm_init and memblock declarations from internal.h"
Previous message: Mike Rapoport (Microsoft): "[PATCH v2 3/3] mm: split out vmalloc declarations from internal.h"
Next in thread: Dan Carpenter: "Re: [PATCH] ALSA: oss: Drop redundant nonseekable_open() return check"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Dan Carpenter

Date: Thu Jul 09 2026 - 06:08:52 EST

On Thu, Jul 02, 2026 at 12:02:36PM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> nonseekable_open() always returns 0, so the error check is unnecessary.
> Remove the dead error handling path.

The idea is that it might return errors in the future.

Also the patch is kind of sloppy...

regards,
dan carpenter