Re: [PATCH v2 2/2] iio: dac: dac8163: Add driver for DAC8163
From: Lukas
Date: Thu Jul 09 2026 - 06:40:39 EST
On Wed, Jul 08, 2026 at 02:32:01PM +0300, Andy Shevchenko wrote:
>
> At the first glance it seems I already commented on the issues in this driver.
> Yes, I see that I commented
>
> "Leave trailing commas in the non-terminator entries here and there."
>
> and in several places in this version it has not been addressed.
> Taking into account this I don't want to go through and check what
> else is missing, so please go again to v1 and carefully read *all*
> the comments and either address them, or explain why it's not done.
>
You are right, i forgot to change that in several places. I think i got
lost a little bit due to the amount of changes. I will make sure to
carefully check that i didnt miss anything before sending v3.
Thanks for taking the time.
Best regards
Lukas