Re: [PATCH v2 2/5] gpu: nova: Add DRM registration data

[Alexandre Courbot]

Title prefix should be "drm: nova:" I guess?

On Thu Jul 9, 2026 at 5:52 PM JST, Alistair Popple wrote:
> Currently the nova-drm stub driver doesn't really interact with a real
> device, so it doesn't have any registration data and has no way to call
> into nova-core.
>
> To allow for this add a DrmRegData type which will hold a reference to
> the NovaCoreApi associated with the auxbus device.
>
> Signed-off-by: Alistair Popple <apopple@xxxxxxxxxx>
> Suggested-by: Danilo Krummrich <dakr@xxxxxxxxxx>
>
> ---
>
> Changes from v1:
>
>  - Drop unrelated device::Bound removal.
>  - Switch exisiting import to vertical style.
>  - s/allow(dead_code)/expect(unused)/
> ---
>  drivers/gpu/drm/nova/driver.rs | 16 ++++++++++++++--
>  drivers/gpu/drm/nova/file.rs   | 12 ++++++++----
>  2 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index 739690bc2db5..0204d1cee6a5 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -1,5 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  
> +use core::pin::Pin;
> +
>  use kernel::{
>      auxiliary,
>      device::{
> @@ -17,6 +19,7 @@
>  
>  use crate::file::File;
>  use crate::gem::NovaObject;
> +use nova_core::api::NovaCoreApi;

nit: Let's add a blank line between the `crate` and `nova_core` imports.