Re: [PATCH v3 09/14] vfs: add O_CREAT|O_DIRECTORY to open*(2)

[Jori Koolstra]

> Op 09-07-2026 16:21 CEST schreef Christian Brauner <brauner@xxxxxxxxxx>:
> 
>  
> > Maybe just backport -EINVAL to every kernel since introducing openat2(2) then
> > that can be used as a test.
> > 
> > But that is an issue if openat2 is blocked. I don't know enough about blocking
> > syscalls to know if that is a big issue or not or whether it can be worked around.
> > But something like this seems reasonable.
> 
> Please just send a new version with the relevant issues addressed.
> The last comment clearly didn't even bother to figure out that nearly
> all LTSes return -EINVAL for the combination. 5.10 and 5.15 fail as well
> but are broken because apparently they didn't get the actual backport
> years ago. They die in December. And upstream doesn't care about
> Back-To-The-Future Frankenstein kernels.

Yes I will this weekend. I'll address your and Neil's feedback (thanks for that!)
and also split it up, so that the faulty audit handling does not block the rest.
But I have to be careful as lookup_open() code is a bit finicky and easy to
miss stupid stuff (Sashiko caught me a couple times). 

I also still need to prepare my OSS talk and I have a full-time non-Linux job
(hopefully not forever), plus trying to do some reviews. So I just didn't get
around to it yet :(

Best,
Jori.