Re: [PATCH v2 0/3] mm: split a couple of headers from internal.h

[Lorenzo Stoakes]

On Thu, Jul 09, 2026 at 12:21:12PM +0200, David Hildenbrand (Arm) wrote:
> On 7/9/26 12:09, Vlastimil Babka (SUSE) wrote:
> > On 7/9/26 12:00, Mike Rapoport (Microsoft) wrote:
> >> mm/internal.h becomes more and more bloated.
> >>
> >> Split declarations related to mm_init, memblock, vmalloc and sparse into
> >> new headers.
> >>
> >> ---
> >> v2 changes:
> >> * fix fallouts of rebase fixups of checkpatch warnings
> >>
> >> v1: https://patch.msgid.link/20260709-internal-h-v1-0-956d5092782d@xxxxxxxxxx
> >>
> >> ---
> >> Mike Rapoport (Microsoft) (3):
> >>       mm: split out mm_init and memblock declarations from internal.h
> >>       mm: split out sparse declarations from internal.h
> >>       mm: split out vmalloc declarations from internal.h
> >>
> >>  MAINTAINERS                        |   3 +
> >>  kernel/liveupdate/kexec_handover.c |   3 +-
> >>  mm/cma.c                           |   1 +
> >>  mm/execmem.c                       |   1 +
> >>  mm/hugetlb.c                       |   1 +
> >>  mm/internal.h                      | 183 -------------------------------------
> >>  mm/kmsan/hooks.c                   |   1 +
> >>  mm/kmsan/shadow.c                  |   1 +
> >>  mm/memblock.c                      |   1 +
> >>  mm/memory_hotplug.c                |   1 +
> >>  mm/mm_init.c                       |   3 +
> >>  mm/mm_init.h                       | 120 ++++++++++++++++++++++++
> >>  mm/page_alloc.c                    |   1 +
> >>  mm/percpu-vm.c                     |   1 +
> >>  mm/sparse-vmemmap.c                |   2 +
> >>  mm/sparse.c                        |   2 +
> >>  mm/sparse.h                        |  63 +++++++++++++
> >>  mm/vmalloc.c                       |   1 +
> >>  mm/vmalloc.h                       |  46 ++++++++++

One thing to be wary of, and I mean I'm going to get a bunch of conflicts with
my mega series, but anythign that uses vma's should use internal.h rather than
vma.h directly (the mega series touches this).

But nothing you changed does use VMAs afaict so should be good.


> >>  19 files changed, 251 insertions(+), 184 deletions(-)
> >
> > Sounds good
> >
> > Acked-by: Vlastimil Babka (SUSE) <vbabka@xxxxxxxxxx>
>
> Agreed
>
> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

Oh hey me too! <3

Acked-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>

>
> --
> Cheers,
>
> David

Cheers, Lorenzo