Re: [PATCH v12 3/6] media: qcom: camss: Add support to populate sub-devices

[Frank Li]

On Wed, Jul 08, 2026 at 01:06:57AM +0100, Bryan O'Donoghue wrote:
> Use devm_of_platform_populate() to populate subs in the tree.
>
> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 2123f6388e3d7..95e655a8b6aa0 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -16,6 +16,7 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/of_graph.h>
> +#include <linux/of_platform.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/pm_domain.h>
>  #include <linux/slab.h>
> @@ -5362,6 +5363,8 @@ static int camss_probe(struct platform_device *pdev)
>  	if (!camss)
>  		return -ENOMEM;
>
> +	devm_of_platform_populate(dev);
> +

Need check return value for all devm_*()

what's happen

     camss {
	phys = <&phya>;

	phya: phy{
	}
     }

Can device defer probe handle cyclic dependence? phy driver may ready later,
following phy request will be defer and cause of_platform_depopulate(),
then phy device will be removed.

Frank

>  	camss->res = of_device_get_match_data(dev);
>
>  	atomic_set(&camss->ref_count, 0);
>
> --
> 2.54.0
>