Re: [PATCH] powerpc/prom: Remove redundant early_init_dt_scan_root() call

From: IBM

Date: Thu Jul 09 2026 - 12:10:58 EST


Sourabh Jain <sourabhjain@xxxxxxxxxxxxx> writes:

> Commit 554b66233623 ("of/fdt: Scan the root node properties earlier")
> moved the invocation of early_init_dt_scan_root() into
> early_init_dt_verify().
>
> early_init_devtree() already calls early_init_dt_verify(), so the root
> node properties are parsed before reaching the explicit call in this
> function.
>
> Keeping the call here results in scanning the root node twice. Remove
> the redundant call and rely on the invocation from
> early_init_dt_verify().
>
> This change keeps the behavior the same and removes an unnecessary
> duplicate call.
>

yup. Nice catch! LGTM. Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>