Re: [PATCH v3 1/2] PM: runtime: Only set runtime_error on suspend callback failures

From: Mark Brown

Date: Thu Jul 09 2026 - 12:36:40 EST


On Mon, Jul 06, 2026 at 02:23:09PM +0530, Praveen Talari wrote:
> When a runtime resume callback returns an error, rpm_callback() sets
> power.runtime_error on the device. This causes all subsequent calls to
> rpm_resume() to return -EINVAL immediately at the top of the function
> without invoking the callback again, making the failure permanent until
> runtime PM is explicitly re-initialized.
>
> Unlike suspend failures, resume failures should be retryable. If a
> device's resume callback fails, there is no reason to permanently block
> future resume attempts on that device and all of its consumers.

runtime_pm.rst still says

* If the resume callback returns an error code, the PM core regards this as a
fatal error and will refuse to run the helper functions described in Section
4 for the device, until its status is directly set to either 'active', or
'suspended' (by means of special helper functions provided by the PM core
for this purpose).

which needs an update now?

Attachment: signature.asc
Description: PGP signature