Re: [PATCH v12 4/6] media: qcom: camss: Add legacy_phy flag to SoC definition structures

[Loic Poulain]

On Wed, Jul 8, 2026 at 2:07 AM Bryan O'Donoghue
<bryan.odonoghue@xxxxxxxxxx> wrote:
>
> Flag which SoCs have legacy - builtin PHY code. This will be useful in
> subsequent patches to inform PHY bringup logic if legacy bindings are
> available.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/platform/qcom/camss/camss.c | 17 +++++++++++++++++
>  drivers/media/platform/qcom/camss/camss.h |  1 +
>  2 files changed, 18 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 95e655a8b6aa0..e814a96953b1b 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -5512,6 +5512,7 @@ static void camss_remove(struct platform_device *pdev)
>
>  static const struct camss_resources msm8916_resources = {
>         .version = CAMSS_8x16,
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_8x16,
>         .csid_res = csid_res_8x16,
>         .ispif_res = &ispif_res_8x16,
> @@ -5523,6 +5524,7 @@ static const struct camss_resources msm8916_resources = {
>
>  static const struct camss_resources msm8939_resources = {
>         .version = CAMSS_8x39,
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_8x39,
>         .csid_res = csid_res_8x39,
>         .ispif_res = &ispif_res_8x39,
> @@ -5534,6 +5536,7 @@ static const struct camss_resources msm8939_resources = {
>
>  static const struct camss_resources msm8953_resources = {
>         .version = CAMSS_8x53,
> +       .legacy_phy = true,
>         .icc_res = icc_res_8x53,
>         .icc_path_num = ARRAY_SIZE(icc_res_8x53),
>         .csiphy_res = csiphy_res_8x96,
> @@ -5547,6 +5550,7 @@ static const struct camss_resources msm8953_resources = {
>
>  static const struct camss_resources msm8996_resources = {
>         .version = CAMSS_8x96,
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_8x96,
>         .csid_res = csid_res_8x96,
>         .ispif_res = &ispif_res_8x96,
> @@ -5558,6 +5562,7 @@ static const struct camss_resources msm8996_resources = {
>
>  static const struct camss_resources qcm2290_resources = {
>         .version = CAMSS_2290,
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_2290,
>         .csid_res = csid_res_2290,
>         .vfe_res = vfe_res_2290,
> @@ -5571,6 +5576,7 @@ static const struct camss_resources qcm2290_resources = {
>  static const struct camss_resources qcs8300_resources = {
>         .version = CAMSS_8300,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_8300,
>         .tpg_res = tpg_res_8775p,
>         .csid_res = csid_res_8775p,
> @@ -5587,6 +5593,7 @@ static const struct camss_resources qcs8300_resources = {
>  static const struct camss_resources sa8775p_resources = {
>         .version = CAMSS_8775P,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_8775p,
>         .tpg_res = tpg_res_8775p,
>         .csid_res = csid_res_8775p,
> @@ -5602,6 +5609,7 @@ static const struct camss_resources sa8775p_resources = {
>
>  static const struct camss_resources sdm660_resources = {
>         .version = CAMSS_660,
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_660,
>         .csid_res = csid_res_660,
>         .ispif_res = &ispif_res_660,
> @@ -5613,6 +5621,7 @@ static const struct camss_resources sdm660_resources = {
>
>  static const struct camss_resources sdm670_resources = {
>         .version = CAMSS_845,
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_670,
>         .csid_res = csid_res_670,
>         .vfe_res = vfe_res_670,
> @@ -5624,6 +5633,7 @@ static const struct camss_resources sdm670_resources = {
>  static const struct camss_resources sdm845_resources = {
>         .version = CAMSS_845,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_845,
>         .csid_res = csid_res_845,
>         .vfe_res = vfe_res_845,
> @@ -5635,6 +5645,7 @@ static const struct camss_resources sdm845_resources = {
>  static const struct camss_resources sm6150_resources = {
>         .version = CAMSS_6150,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_sm6150,
>         .csid_res = csid_res_sm6150,
>         .vfe_res = vfe_res_sm6150,
> @@ -5661,6 +5672,7 @@ static const struct camss_resources sm6350_resources = {
>  static const struct camss_resources sm8250_resources = {
>         .version = CAMSS_8250,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_8250,
>         .csid_res = csid_res_8250,
>         .vfe_res = vfe_res_8250,
> @@ -5674,6 +5686,7 @@ static const struct camss_resources sm8250_resources = {
>  static const struct camss_resources sc8280xp_resources = {
>         .version = CAMSS_8280XP,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_sc8280xp,
>         .csid_res = csid_res_sc8280xp,
>         .ispif_res = NULL,
> @@ -5688,6 +5701,7 @@ static const struct camss_resources sc8280xp_resources = {
>  static const struct camss_resources sc7280_resources = {
>         .version = CAMSS_7280,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_7280,
>         .csid_res = csid_res_7280,
>         .vfe_res = vfe_res_7280,
> @@ -5701,6 +5715,7 @@ static const struct camss_resources sc7280_resources = {
>  static const struct camss_resources sm8550_resources = {
>         .version = CAMSS_8550,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_8550,
>         .csid_res = csid_res_8550,
>         .vfe_res = vfe_res_8550,
> @@ -5715,6 +5730,7 @@ static const struct camss_resources sm8550_resources = {
>  static const struct camss_resources sm8650_resources = {
>         .version = CAMSS_8650,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_sm8650,
>         .csid_res = csid_res_sm8650,
>         .csid_wrapper_res = &csid_wrapper_res_sm8550,
> @@ -5729,6 +5745,7 @@ static const struct camss_resources sm8650_resources = {
>  static const struct camss_resources x1e80100_resources = {
>         .version = CAMSS_X1E80100,
>         .pd_name = "top",
> +       .legacy_phy = true,
>         .csiphy_res = csiphy_res_x1e80100,
>         .tpg_res = tpg_res_x1e80100,
>         .csid_res = csid_res_x1e80100,
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index 93d691c8ac63b..698694d3064ea 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -107,6 +107,7 @@ enum icc_count {
>  struct camss_resources {
>         enum camss_version version;
>         const char *pd_name;
> +       const bool legacy_phy;
>         const struct camss_subdev_resources *csiphy_res;
>         const struct camss_subdev_resources *tpg_res;
>         const struct camss_subdev_resources *csid_res;
>
> --
> 2.54.0
>