Re: [PATCH v3 15/17] selftests/verification: Fix wrong errexit assumption

[Wen Yang]

On 6/25/26 20:14, Gabriele Monaco wrote:
> RV selftest rely on bash errexit (set -e) to terminate with error, when
> a step is expected to return false, the following syntax is used:
>
>    ! cmd
>
> This however prevents the test from exiting when cmd is false (desired)
> but doesn't exit if cmd is true, since commands prefixed with ! are
> explicitly excluded from errexit.
>
> Use the syntax
>
>    ! cmd || false
>
> Which ends up checking the exit value of ! cmd and supplies a false
> command for errexit to evaluate.
>
> Signed-off-by: Gabriele Monaco <gmonaco@xxxxxxxxxx>


Reviewed-by: Wen Yang <wen.yang@xxxxxxxxx>


--
Best wishes,
Wen