Re: [PATCH v2 01/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8186

[Conor Dooley]

On Thu, Jul 09, 2026 at 04:01:49PM +0200, AngeloGioacchino Del Regno wrote:
> On 7/9/26 15:42, Louis-Alexis Eyraud wrote:
> > Both MT8186 clock controllers dt-bindings (clock and sys-clock)
> > document the '#clock-cells' property but do not enforce it as required
> > property.
> > As clock provider nodes should define this property in devicetrees, add
> > it to the required property list in both its dt-bindings files.
> > 
> > Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@xxxxxxxxxxxxx>
> 
> Though you could've done that in one commit, or just skipped the additions in all
> of mt8186/92/95 and went directly for the new one... IMO, it's ok as you're showing
> that there was an actual mistake on the bindings for clock controllers.
> 
> Same comment applies for patch 2 and 3, btw.
> 
> Anyway:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> 

Prob should have a fixes tag too.

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: not-applicable

(sorry if you got this twice, mutt crashed while sending)

Attachment: signature.asc
Description: PGP signature