Re: [PATCH v2 08/18] dt-bindings: clock: mediatek: Add MT8189 clocks

[Conor Dooley]

On Thu, Jul 09, 2026 at 04:05:35PM +0200, AngeloGioacchino Del Regno wrote:
> On 7/9/26 15:42, Louis-Alexis Eyraud wrote:
> > Add dt schema and IDs for the clocks of MediaTek MT8189 SoC.
> > The MT8189 clock IP provide clock control for main system
> > (apmixedsys, topcksys and vlpcksys) and subsys (eg. peri, scp,
> > ufs...).
> > 
> > Also, add compatible for frequency hopping and spread spectrum clock
> > functionality and reset controller header file for MT8189 UFS reset
> > controller support.
> > 
> > Co-developed-by: Irving-CH Lin <irving-ch.lin@xxxxxxxxxxxx>
> > Signed-off-by: Irving-CH Lin <irving-ch.lin@xxxxxxxxxxxx>
> > Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@xxxxxxxxxxxxx>
> 
> Both the commit description and title are misleading, as in, you're not adding
> MT8189 clocks, but *both* clocks *and* resets.
> 
> Fix it please.
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

And
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

pw-bot: changes-requested

Cheers,
Conor.

> 
> > ---
> >   .../bindings/clock/mediatek,mt8186-clock.yaml      |  15 +
> >   .../bindings/clock/mediatek,mt8186-fhctl.yaml      |   1 +
> >   .../bindings/clock/mediatek,mt8186-sys-clock.yaml  |   5 +
> >   include/dt-bindings/clock/mediatek,mt8189-clk.h    | 433 +++++++++++++++++++++
> >   include/dt-bindings/reset/mediatek,mt8189-resets.h |  17 +
> >   5 files changed, 471 insertions(+)
> > 
> 
>

Attachment: signature.asc
Description: PGP signature