Re: [RFC PATCH 2/2] PM: EM: Validate new_table in em_dev_update_perf_domain()

[Lukasz Luba]

On 7/10/26 09:24, Xuewen Yan wrote:
> Add an explicit check for the new_table parameter in
> em_dev_update_perf_domain() to ensure it is not NULL or an
> ERR_PTR before proceeding with the update.
>
> Signed-off-by: Xuewen Yan <xuewen.yan@xxxxxxxxxx>
> ---
>   kernel/power/energy_model.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
> index 277aaf1b19da..4d75e1b3c20e 100644
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -331,7 +331,7 @@ int em_dev_update_perf_domain(struct device *dev,
>   	struct em_perf_table *old_table;
>   	struct em_perf_domain *pd;
>   
> -	if (!dev)
> +	if (!dev || IS_ERR_OR_NULL(new_table))
>   		return -EINVAL;
>   
>   	/* Serialize update/unregister or concurrent updates */


Make sense to check that and catch possible issue this way.

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>