Re: [PATCH 02/16] dt-bindings: interrupt-controller: Describe EIP-201 AIC

[Miquel Raynal]

Hello,

>> --- /dev/null
>> +++ b/include/dt-bindings/interrupt-controller/inside-secure,safexcel-eip201.h
>> @@ -0,0 +1,14 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +
>> +#ifndef _DT_BINDINGS_IRQ_SAFEXCEL_EIP201_AIC_H
>> +#define _DT_BINDINGS_IRQ_SAFEXCEL_EIP201_AIC_H
>> +
>> +#define AIC_PKA_INT0 0
>> +#define AIC_PKA_INT1 1
>> +#define AIC_PKA_INT2 2
>> +#define AIC_TRNG_INT 3
>> +#define AIC_RESERVED 4
>> +#define AIC_SL_ERR_INT  5
>> +#define AIC_PROTECTION_INT 6
>> +
>> +#endif
>
> This interrupt mapping is specific to the EIP-150. The EIP-201 is also
> integrated
> into other accelerators, such as the EIP-97, EIP-196, and EIP-197, and the
> interrupt mapping is likely different there. Maybe it would be better to use
> eip150 name instead of eip201?

I was about to rename the file (and the ifndef/define section), but in
the end I feel like it does not actually make sense to do that, because
it would require to include one header per container in the
driver. Instead, I propose another way: let's keep the file name as-is,
but mention with a comment above the definitions that these are specific
to the EIP-150 implementation. This way, if someone want to reuse the
controller for another integration, they can just add their own
interrupt names/numbers below, with another comment stating the name of
the container they apply to.

For future people who would like to extend this driver to another
container: mind that there is currently a list of "unused" interrupts in
the v2 of the driver (in the generic chip structure). This list may
simply go away if one needs one of the three interrupts currently
listed.

Thanks,
Miquèl