Re: [PATCH v3] platform/x86: asus-wireless: Fail probe when there is no ACPI match

From: Ilpo Järvinen

Date: Fri Jul 10 2026 - 06:28:03 EST


On Fri, 10 Jul 2026 17:43:55 +0800, Linmao Li wrote:

> Every platform driver can be forced to match a device that does not match
> its list of device IDs because of device_match_driver_override(), so
> platform drivers that rely on the existence of a device ACPI companion
> object need to verify its presence.
>
> asus_wireless_probe() returns success when acpi_match_acpi_device()
> finds no match, leaving behind an input device that never reports
> anything because the notify handler is not installed. Worse, when the
> driver is force-bound to a device without an ACPI companion, probe
> still succeeds and stores a NULL companion pointer, which
> asus_wireless_remove() later passes to acpi_dev_remove_notify_handler(),
> leading to a NULL pointer dereference on unbind.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: asus-wireless: Fail probe when there is no ACPI match
commit: 4aefd66ef7822cf7d3f53146dcee0b71021ed2b7

--
i.