[PATCH 2/2] bus: Remove redundant dev_err()/dev_err_probe()
From: Pan Chuang
Date: Fri Jul 10 2026 - 07:10:32 EST
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/bus/omap_l3_noc.c | 7 +------
drivers/bus/sunxi-rsb.c | 3 +--
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index eb1ba6319fda..45f3f793976c 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
@@ -278,17 +278,12 @@ static int omap_l3_probe(struct platform_device *pdev)
l3->debug_irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,
IRQF_NO_THREAD, "l3-dbg-irq", l3);
- if (ret) {
- dev_err(l3->dev, "request_irq failed for %d\n",
- l3->debug_irq);
+ if (ret)
return ret;
- }
l3->app_irq = platform_get_irq(pdev, 1);
ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,
IRQF_NO_THREAD, "l3-app-irq", l3);
- if (ret)
- dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);
return ret;
}
diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
index daf0ea563e47..671c9b33e783 100644
--- a/drivers/bus/sunxi-rsb.c
+++ b/drivers/bus/sunxi-rsb.c
@@ -787,8 +787,7 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq, sunxi_rsb_irq, 0, RSB_CTRL_NAME, rsb);
if (ret)
- return dev_err_probe(dev, ret,
- "can't register interrupt handler irq %d\n", irq);
+ return ret;
ret = sunxi_rsb_hw_init(rsb);
if (ret)
--
2.34.1