Re: [PATCH net v2 1/2] net: dsa: mv88e6xxx: write the ATU FID register on 88E6141/88E6341

[Andrew Lunn]

> index e966e7c4cc5de..aca64fd4cb95c 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.h
> +++ b/drivers/net/dsa/mv88e6xxx/chip.h
> @@ -165,16 +165,20 @@ struct mv88e6xxx_info {
>  	 */
>  	bool dual_chip;
>  
> +	/* Has a dedicated ATU FID register. */
> +	bool atu_fid_reg;
> +
> +	/* Supports PTP */
> +	bool ptp_support;
> +

Moving structure members around to make it pack better should not be
mixed with a fix. Add the atu_fid_reg next to other bools. But please
move the ptp_support in another patch, sent to net-next.

> -	const struct mv88e6xxx_ops *ops;
>  
> -	/* Supports PTP */
> -	bool ptp_support;
> +	const struct mv88e6xxx_ops *ops;
>  

The rest of the patch looks fine.

    Andrew