RE: [PATCH net-next v3] net: mana: Add handler for sriov configure

[Haiyang Zhang]

> -----Original Message-----
> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, July 8, 2026 4:59 PM
> To: linux-hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; KY Srinivasan
> <kys@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; Wei Liu
> <wei.liu@xxxxxxxxxx>; Dexuan Cui <DECUI@xxxxxxxxxxxxx>; Long Li
> <longli@xxxxxxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; David S.
> Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Simon Horman
> <horms@xxxxxxxxxx>; Erni Sri Satya Vennela <ernis@xxxxxxxxxxxxxxxxxxx>;
> Dipayaan Roy <dipayanroy@xxxxxxxxxxxxxxxxxxx>; Aditya Garg
> <gargaditya@xxxxxxxxxxxxxxxxxxx>; Shradha Gupta
> <shradhagupta@xxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Paul Rosswurm <paulros@xxxxxxxxxxxxx>
> Subject: [PATCH net-next v3] net: mana: Add handler for sriov configure
> 
> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> 
> Add callback function for the pci_driver / sriov_configure.
> 
> It asks the NIC to provide certain number of VFs, or disable
> VFs if the request is zero.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> ---
> v3:
>   Updated sriov disabling paths suggested by Paolo Abeni
> 
> v2:
>   No longer change VF autoprobe as discussed with Leon Romanovsky and
> Bjorn Helgaas.
> 
> ---
>  .../net/ethernet/microsoft/mana/gdma_main.c   | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> index aef3b77229c1..80a9118a90bc 100644
> --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> @@ -2456,6 +2456,8 @@ static void mana_gd_remove(struct pci_dev *pdev)
>  {
>  	struct gdma_context *gc = pci_get_drvdata(pdev);
> 
> +	pci_disable_sriov(pdev);
> +
>  	mana_rdma_remove(&gc->mana_ib);
>  	mana_remove(&gc->mana, false);
> 
> @@ -2517,6 +2519,8 @@ static void mana_gd_shutdown(struct pci_dev *pdev)
> 
>  	dev_info(&pdev->dev, "Shutdown was called\n");
> 
> +	pci_disable_sriov(pdev);
> +

I will remove this unnecessary pci_disable_sriov() as found by AI review,
and submit an updated patch.

- Haiyang