Re: [PATCH v1] PCI: acpiphp_ibm: Do not use uninitialized device_class

[Bjorn Helgaas]

On Mon, Jul 06, 2026 at 02:40:22PM +0200, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
> 
> Passing an uninitialized pnp.device_class string to
> acpi_bus_generate_netlink_event() is effectively equivalent
> to passing an empty string literal to it.
> 
> Accordingly, make the driver do the latter instead of doing the
> former.
> 
> No intentional functional impact.
> 
> This will facilitate the removal of device_class from struct
> acpi_device_pnp in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Applied to pci/hotplug for v7.3, thanks!

> ---
>  drivers/pci/hotplug/acpiphp_ibm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/acpiphp_ibm.c b/drivers/pci/hotplug/acpiphp_ibm.c
> index f8016ed24523..7337bd1ac6df 100644
> --- a/drivers/pci/hotplug/acpiphp_ibm.c
> +++ b/drivers/pci/hotplug/acpiphp_ibm.c
> @@ -258,8 +258,7 @@ static void ibm_handle_events(acpi_handle handle, u32 event, void *context)
>  
>  	if (subevent == 0x80) {
>  		pr_debug("%s: generating bus event\n", __func__);
> -		acpi_bus_generate_netlink_event(note->device->pnp.device_class,
> -						  dev_name(&note->device->dev),
> +		acpi_bus_generate_netlink_event("", dev_name(&note->device->dev),
>  						  note->event, detail);
>  	} else
>  		note->event = event;
> -- 
> 2.51.0
> 
> 
> 
>