Re: [RFC PATCH v3 01/27] x86/apic: Propagate APIC_SPIV writes to hv for Secure AVIC

From: Borislav Petkov

Date: Sat Jul 11 2026 - 00:37:35 EST


On Fri, Jul 10, 2026 at 08:32:23PM +0530, Naveen N Rao wrote:
> Guest doesn't boot without this change.

Then give the commit message a second try and explain exactly the situation.

> APIC_SPIV has a bit to (soft-)disable the APIC. It starts off disabled
> and the kernel has to write to it to enable the APIC. If writes from the
> guest are not propagated to KVM, KVM does not deliver interrupts to the
> guest since the APIC is disabled as far as it is concerned.
>
> I will update the commit log with these details.

Oh yeah!

> I was genuinely unaware of this. Just so I get this right:
> - Add just the 'Sob:' for patches from others that I post un-modified
> (without a Co-developed-by: tag)

Yes, if you're handling the patch - it passes through you - SOB.

> - Add 'Co-developed-by:' if I make any changes to the patch (commit log
> included?)

Co-developed is when you've put a more serious effort into the patch than just
touch ups, I'd say.

But we have it all documented:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

especially:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

which answers your questions exactly.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette