Re: [PATCH bpf-next 2/2] bpf: Remove unnecessary dup/restore subprog_starts and prog clone
From: Xu Kuohai
Date: Sat Jul 11 2026 - 03:41:07 EST
On 7/11/2026 2:28 PM, bot+bpf-ci@xxxxxxxxxx wrote:
diff --git a/include/linux/filter.h b/include/linux/filter.h
index 25148865f9c76..232c02031fecb 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
[ ... ]
diff --git a/kernel/bpf/fixups.c b/kernel/bpf/fixups.c
index 37f22eb418540..80c8beb45ea04 100644
--- a/kernel/bpf/fixups.c
+++ b/kernel/bpf/fixups.c
[ ... ]
@@ -1309,13 +1309,13 @@ int bpf_jit_subprogs(struct bpf_verifier_env *env)
return 0;
out_jit_err:
- if (blinded) {
+ if (cloned) {
bpf_jit_prog_release_other(orig_prog, prog);
- /* roll back to the clean original prog */
+ /* roll back to the clean original prog */
prog = env->prog = orig_prog;
This isn't a bug, but does the comment need the extra space between
'clean' and 'original'?
No, the extra space should be removed.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/29141596379