Re: [PATCH net] macsec: fix promiscuity refcount leak in macsec_dev_open()
From: patchwork-bot+netdevbpf
Date: Sat Jul 11 2026 - 07:01:05 EST
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@xxxxxxxxxx>:
On Sun, 5 Jul 2026 19:36:29 +0800 you wrote:
> When a MACsec interface with IFF_PROMISC set is brought up on top of a
> device that has hardware offload enabled, macsec_dev_open() first calls
> dev_set_promiscuity(real_dev, 1) and then propagates the open to the
> offload device. If that propagation fails, the error path jumps to the
> clear_allmulti label, which only reverts allmulti and the unicast
> address. The promiscuity taken on the lower device is never dropped, so
> real_dev is left permanently stuck in promiscuous mode. Its promiscuity
> count can no longer be balanced from software.
>
> [...]
Here is the summary with links:
- [net] macsec: fix promiscuity refcount leak in macsec_dev_open()
https://git.kernel.org/netdev/net/c/7410d11460eb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html