Re: [PATCH v2 3/3] regulator: axp20x: add support for the AXP318W
From: Jerome Brunet
Date: Sat Jul 11 2026 - 08:37:53 EST
On ven. 10 juil. 2026 at 18:00, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Fri, Jul 10, 2026 at 06:19:27PM +0200, Jerome Brunet wrote:
>
>> +#define AXP_DESC_RANGES_DELAY_OPS(_family, _id, _match, _supply, _ranges, \
>> + _n_voltages, _vreg, _vmask, _ereg, _emask, \
>> + _ramp_delay, _ops) \
>> [_family##_##_id] = { \
>> .name = (_match), \
>> .supply_name = (_supply), \
>> @@ -436,10 +481,23 @@
>> .enable_mask = (_emask), \
>> .linear_ranges = (_ranges), \
>> .n_linear_ranges = ARRAY_SIZE(_ranges), \
>> - .ramp_delay = (_ramp_delay), \
>> + .ramp_delay = (_ramp_delay), \
>> .ops = &axp20x_ops_range, \
>
> This macro takes but ignores an ops parameter.
Indeed, completely messed up as noted in reply to the cover
letter. Sorry about that. Tested something, sent something else (and
other mistakes ...)
--
Jerome