Re: [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE

[Arnd Bergmann]

On Sat, Jul 11, 2026, at 15:03, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
>
> Replace 'select' with 'depends on'.
>
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>


Good catch, but I wonder if this is actually a real dependency
at all. What would happen if you just remove the 'select' line
here and build a polarfire kernel that only supports
host or gadget mode but not dual-role?

       Arnd