Re: [PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema

[Krzysztof Kozlowski]

On 11/07/2026 12:55, Mikhail Lukianchikov wrote:
> The conversion adds proper validation for the 'microchip,led-modes'
> property inside the MDIO node.

It was in the old binding, so I don't understand this part. You list
here changes done to the binding during conversion. I see no change, so
what does this refer to?

> 
> Signed-off-by: Mikhail Lukianchikov <avermoal@xxxxxxxxx>
> ---
> Changes in v3:
>  - Added $ref to ethernet-phy.yaml for PHY node to use standard PHY properties.
>  - Dropped redundant PHY description and manual 'reg' property definition.
>  - Dropped root node and fake compatibles in the example.
> 
> Link to v2: https://lore.kernel.org/netdev/20260709181724.24682-2-avermoal@xxxxxxxxx
> 
>  .../bindings/net/microchip,lan7800.yaml       | 96 +++++++++++++++++++
>  .../bindings/net/microchip,lan78xx.txt        | 53 ----------
>  MAINTAINERS                                   |  3 +-
>  3 files changed, 97 insertions(+), 55 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> new file mode 100644
> index 000000000000..730999d11e8a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller
> +
> +maintainers:
> +  - Rengarajan Sundararajan <Rengarajan.S@xxxxxxxxxxxxx>
> +
> +description:
> +  The LAN7800/LAN7801/LAN7850 devices are usually configured by
> +  programming their OTP or with an external EEPROM, but some
> +  platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree
> +  properties, if present, override the OTP and EEPROM.
> +
> +allOf:
> +  - $ref: /schemas/usb/usb-device.yaml#
> +  - $ref: /schemas/net/ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - usb424,7800
> +      - usb424,7801
> +      - usb424,7850
> +
> +  reg:
> +    maxItems: 1
> +    description: USB port number
> +
> +  local-mac-address:
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 6
> +    maxItems: 6
> +    description:
> +      MAC address to use if not stored in OTP or EEPROM. If present,
> +      overrides OTP/EEPROM.

Drop local-mac-address, already coming from network-class schema.

> +
> +  mdio:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false


...

> diff --git a/MAINTAINERS b/MAINTAINERS
> index f37a81950e25..157a677a284f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27928,10 +27928,9 @@ F:	drivers/usb/isp1760/*
>  USB LAN78XX ETHERNET DRIVER
>  M:	Thangaraj Samynathan <Thangaraj.S@xxxxxxxxxxxxx>
>  M:	Rengarajan Sundararajan <Rengarajan.S@xxxxxxxxxxxxx>
> -M:	UNGLinuxDriver@xxxxxxxxxxxxx

I don't understand this change. No one requested this. Not explained in
commit msg at all.

>  L:	netdev@xxxxxxxxxxxxxxx
>  S:	Maintained
> -F:	Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> +F:	Documentation/devicetree/bindings/net/microchip,lan7800.yaml
>  F:	drivers/net/usb/lan78xx.*
>  F:	include/dt-bindings/net/microchip-lan78xx.h
>  


Best regards,
Krzysztof