Re: [PATCH v7 17/17] docs: iio: add documentation for ad9910 driver

[Jonathan Cameron]

On Tue, 07 Jul 2026 15:04:38 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@xxxxxxxxxx> wrote:

> From: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> 
> Add documentation for the AD9910 DDS IIO driver, which describes channels,
> DDS modes, attributes and ABI usage examples.
> 
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
Based on my slightly tired Saturday afternoon reading I'm happy with how all this
looks now.  Did find one thing to comment on though ;)
> ---
>  Documentation/iio/ad9910.rst | 792 +++++++++++++++++++++++++++++++++++++++++++
>  Documentation/iio/index.rst  |   1 +
>  MAINTAINERS                  |   1 +
>  3 files changed, 794 insertions(+)
> 
> diff --git a/Documentation/iio/ad9910.rst b/Documentation/iio/ad9910.rst
> new file mode 100644
> index 000000000000..ab5223c70c01
> --- /dev/null
> +++ b/Documentation/iio/ad9910.rst

> +
> +  echo 1 > /sys/bus/iio/devices/iio\:device0/out_altcurrent100_powerdown
> \ No newline at end of file

Add one.


There were a few really trivial things sashiko called out in earlier
patches such as %lu for long unsigned prints. I'll just assume you'll
tidy any of those up for v8 + the stuff Andy pointed out.

Otherwise I think this is all looking good.  Nice work on such a complex
device.

Thanks,

Jonathan