Re: [PATCH v2 1/2] dt-bindings: sound: add Texas Instruments TAS2557

[Krzysztof Kozlowski]

On Sat, Jul 11, 2026 at 04:57:20PM +0200, Gianluca Boiano wrote:
> +  ti,imon-slot-no:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TDM TX time slot for current-sense data.
> +    default: 0
> +    minimum: 0
> +    maximum: 7
> +
> +  ti,vmon-slot-no:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TDM TX time slot for voltage-sense data.
> +    default: 2
> +    minimum: 0
> +    maximum: 7
> +
> +  ti,channel:

ti,audio-channel

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Audio slot of the stereo stream reproduced by this device (0 =
> +      left, 1 = right). With stereo firmware this also selects which
> +      per-device tuning set is applied.
> +    enum: [0, 1]
> +    default: 0

Most speakers do not need such property, especially that what do you do
in 4-speaker configuration? I found only two references: awinic,aw87390
and awinic,aw88395.yaml.

 +
> +  firmware-name:
> +    $ref: /schemas/types.yaml#/definitions/string

Wrong type - there is basically no syntax like that (except a few
left-overs which I remove now), so please kindly do not upstrem some old
code. Drop.

You need maxItems.

Best regards,
Krzysztof