回复: Re: 回复: Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@xxxxxxxxxxxxxx>
From: dylanliu050903
Date: Sun Jul 12 2026 - 11:42:15 EST
使用 Proton Mail 安全邮箱发送。
2026年7月12日 星期日 下午 11:05,Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> 来信:
> On Sun, Jul 12, 2026 at 02:56:40PM +0000, dylanliu050903 wrote:
> > 使用 Proton Mail 安全邮箱发送。
> > 2026年7月12日 星期日 下午 10:27,Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> 来信:
> > > You just changed the user/kernel api, right? Are you sure this is ok to
> > > do?
> >
> > I apologize for the oversight; being new to this, I am still learning the
> > ropes and appreciate your patience.
> >
> > You are absolutely right. I acknowledge that changing the sysfs names
> > directly impacts userspace and violates the "never break userspace" rule. I
> > will take a step back and adopt a more conservative approach: I plan to keep
> > the original attribute names as they are to ensure backward compatibility
> > while introducing the new snake_case names as aliases.
> >
> > Would this be an acceptable way to move forward, or would you prefer I handle
> > this cleanup in a different way?
>
> You also should stop sending HTML mails.
>
> The driver is in staging and most likely more work is needed. As for this ABI
> change, it's possible but it needs to be aligned with IIO maintainers and
> reviewers first to understand why the original driver has it and what will be
> needed to fulfil the same / similar if driver becomes part of IIO.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Hi Andy,
First, I apologize for the HTML email earlier. I have fixed my email client settings.I was using the ProtonMail web client instead of `git send-email`, which unexpectedly defaulted to HTML.
Regarding the ABI change: I made a classic beginner mistake. I changed it purely because the `checkpatch.pl` script threw a warning suggesting it should be in snake_case. I blindly followed the script's advice without realizing that I was modifying a user/kernel ABI.
I now understand that ABI stability (and aligning with IIO maintainers for any necessary staging transitions) absolutely takes precedence over resolving style warnings.
Please drop this patch. I will be much more careful with checkpatch warnings involving exposed interfaces in the future.I will also dive deeper into the codebase to ensure my future commits provide real value.
Thank you for your time and the guidance!
Best regards,
Dylan Liu