Re: [PATCH RESEND v5 12/25] drm/msm/dp: factor out _helper variants of bridge ops accepting a panel

[Dmitry Baryshkov]

On Mon, Jun 29, 2026 at 10:14:33PM +0800, Yongxing Mou wrote:
> From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> 
> The atomic bridge callbacks (set_mode / enable / disable /
> post_disable) on dp_display currently hard-code dp->panel. For
> DP MST every stream has its own msm_dp_panel that the MST
> encoder owns, so the same enable/disable sequence needs to be
> invokable against an arbitrary panel.
> 
> Introduce *_helper variants that take struct msm_dp_panel * and
> reduce the existing atomic_* callbacks to thin wrappers that
> pass dp->panel. No SST-path behaviour change.
> 
> Also drop the static qualifier from msm_dp_display_prepare_link()
> and msm_dp_display_unprepare() and change them to take
> struct msm_dp * so the upcoming MST encoder code can drive
> link-level prepare/unprepare uniformly through the public API.
> 
> Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 93 +++++++++++++++++++++++++++----------
>  drivers/gpu/drm/msm/dp/dp_display.h | 12 +++++
>  2 files changed, 80 insertions(+), 25 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


-- 
With best wishes
Dmitry