Re: [PATCH v1 3/4] iio: light: opt4001: Reject integration times with a non-zero seconds part

[Jonathan Cameron]

On Mon, 13 Jul 2026 01:54:50 +0530
Nikhil Gautam <nikhilgtr@xxxxxxxxx> wrote:

> opt4001_write_raw() only looks at val2 when setting the integration
> time, so a write such as 1.000600 is silently accepted as 600 us.
> Return -EINVAL if val is non-zero.
> 
> Signed-off-by: Nikhil Gautam <nikhilgtr@xxxxxxxxx>
Fixes tag definitely makes sense for this one.  Good spot.

> ---
>  drivers/iio/light/opt4001.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c
> index bdb1eadbd450..31a5397926eb 100644
> --- a/drivers/iio/light/opt4001.c
> +++ b/drivers/iio/light/opt4001.c
> @@ -288,6 +288,8 @@ static int opt4001_write_raw(struct iio_dev *indio_dev,
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_INT_TIME:
> +		if (val)
> +			return -EINVAL;
Blank line here.

Otherwise lgtm.

>  		int_time = opt4001_als_time_to_index(val2);
>  		if (int_time < 0)
>  			return int_time;