Re: [PATCH] scsi: ufs: Add support for the aggregated read query opcode

[Hyeoncheol Jeong]

Hi Bart,

On 7/10/26 02:46 PM, Bart Van Assche wrote:
> On 7/9/26 10:45 PM, Hyeoncheol Jeong wrote:
> > struct utp_transfer_cmd_desc {
> >           u8 command_upiu[ALIGNED_UPIU_SIZE];
> > -        u8 response_upiu[ALIGNED_UPIU_SIZE];
> > +        u8 response_upiu[ALIGNED_RSP_UPIU_SIZE];
> >           u8 prd_table[];
> > };
>
> This change increases the size of every CQ entry and also of every LRB
> entry by about 4 KiB. This is not acceptable.

Thanks for the review. You're right — growing the shared
utp_transfer_cmd_desc enlarges the response area for every tag,
which is wasteful. The aggregated read only uses the reserved
(device management) tag, so only that tag needs the big buffer.

Would it be okay to keep utp_transfer_cmd_desc as is and give
just the reserved tag a dedicated 4 KiB response descriptor?
Regular tags and normal I/O would stay unchanged.

Let me know if you'd prefer another approach.

Thanks.