Re: [PATCH 2/3] clk: qcom: ipq5210: Use icc-clk for enabling NoC related clocks

[Varadarajan Narayanan]

On Sun, May 17, 2026 at 09:51:52PM +0300, Dmitry Baryshkov wrote:
> On Fri, May 15, 2026 at 09:11:19PM +0530, Varadarajan Narayanan wrote:
> > On Fri, May 15, 2026 at 04:31:42PM +0300, Dmitry Baryshkov wrote:
> > > On Thu, May 14, 2026 at 09:35:36AM +0530, Varadarajan Narayanan wrote:
> > > > Use the icc-clk framework to enable few clocks to be able to
> > > > create paths and use the peripherals connected on those NoCs.
> > > >
> > > > Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@xxxxxxxxxxxxxxxx>
> > > > ---
> > > >  drivers/clk/qcom/gcc-ipq5210.c | 16 ++++++++++++++++
> > > >  1 file changed, 16 insertions(+)
> > > >
> > > > @@ -2642,6 +2657,7 @@ static struct platform_driver gcc_ipq5210_driver = {
> > > >  	.driver = {
> > > >  		.name   = "qcom,gcc-ipq5210",
> > > >  		.of_match_table = gcc_ipq5210_match_table,
> > > > +		.sync_state = icc_sync_state,
> > >
> > > in Kconfig:
> > >
> > > select INTERCONNECT
> > >
> > > OR
> > >
> > > depends on INTERCONNECT
> >
> > In drivers/clk/qcom/Kconfig, IPQ_GCC_5210 can be selected only if
> > COMMON_CLK_QCOM is enabled. COMMON_CLK_QCOM selects both
> > INTERCONNECT and INTERCONNECT_CLK.
> >
> > Is select (or) depends INTERCONNECT still needed for IPQ_GCC_5210.
> > Please let me know.
>
> I've sent [1], let's see if it gets accepted or not.

Don't see [1] in linux-next yet. Please let me know if I should change ipq5210's
gcc to depend on INTERCONNECT.

Thanks
Varada

[1] https://patch.msgid.link/20260517-qcom-clk-icc-v1-1-1dc6ea8bdcd0@xxxxxxxxxxxxxxxx