Re: [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE

From: Arnd Bergmann

Date: Mon Jul 13 2026 - 02:27:59 EST


On Sun, Jul 12, 2026, at 23:56, Conor Dooley wrote:
> On Sat, Jul 11, 2026 at 04:09:58PM +0100, Julian Braha wrote:
>> On 7/11/26 15:39, Arnd Bergmann wrote:
>> > Good catch, but I wonder if this is actually a real dependency
>> > at all. What would happen if you just remove the 'select' line
>> > here and build a polarfire kernel that only supports
>> > host or gadget mode but not dual-role?
>>
>> The kernel builds just fine for me with USB_MUSB_POLARFIRE_SOC=y and
>> USB_MUSB_DUAL_ROLE=n
>>
> This is the setup I've been using in my development environment for
> (probably) years.
>
> Probably the select should just be deleted.

Ok, so it was probably just a misguided attempt to pick the most
useful configuration by default.

Julian, can you send a new patch to just drop the line?

Arnd