Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy

[Peter Chen]

On 26-07-13 08:26:59, Krzysztof Kozlowski wrote:
> >> And Dmitry already said this at v3.
> > 
> > And I've already responded to his comment in v3:
> > https://lore.kernel.org/linux-usb/ahjYwJtiMsm0BcCh@vbox/
> 
> It does not change the fact that type of phy is implied by compatible,
> thus you do not get a new property.
> 
> 

For USB2 PHY, it has property "phy_type" already, it could extend support
list to eUSB2 like below, dwc3 qcom glue layer could call of_usb_get_phy_mode
or re-use dwc3->hsphy_mode depends on where it needs to use.

diff --git a/drivers/usb/phy/of.c b/drivers/usb/phy/of.c
index 1ab134f45d67..5cbf17d493ad 100644
--- a/drivers/usb/phy/of.c
+++ b/drivers/usb/phy/of.c
@@ -16,6 +16,7 @@ static const char *const usbphy_modes[] = {
 	[USBPHY_INTERFACE_MODE_ULPI]	= "ulpi",
 	[USBPHY_INTERFACE_MODE_SERIAL]	= "serial",
 	[USBPHY_INTERFACE_MODE_HSIC]	= "hsic",
+	[USBPHY_INTERFACE_MODE_EUSB2]	= "eusb2",
 };


-- 

Thanks,
Peter Chen