Re: [PATCH 01/16] dt-bindings: twl-regulator: Add bindings for exposing ti,twl4030-regen

[H. Nikolaus Schaller]

Hi Krzysztof,

Thank you for the feedback.

> Am 13.07.2026 um 09:39 schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
> 
> On Sat, Jul 11, 2026 at 08:01:48AM +0200, H. Nikolaus Schaller wrote:
>> From: Grond <grond66@xxxxxxxxxx>
>> 
>> FIXME: not reflected in the bindings
>> 
>> +Reguired properties:
>> +For twl3040 REGEN signal:
>> + - regulator-min-microvolt:
>> +  - Same meaning as in bindings/regulator/regulator.yaml, but must match
>> +    regulator-max-microvolt.
>> + - regulator-max-microvolt:
>> +  - Same meaning as in bindings/regulator/regulator.yaml, but must match
>> +    regulator-min-microvolt.
>> + - startup-delay-us:
>> +  - Same meaning as in bindings/regulator/fixed-regulator.yaml.
> 
> I don't know what that means.
> 
>> 
>> Signed-off-by: Grond <grond66@xxxxxxxxxx>
> 
> As explicitly written in submitting patches: we do not take anonymous
> contributions.

Thanks for pointing this out. In more than 10 years of contributing, I actually have never run into this specific issue before.

To give some context: this is a contribution we received on our mailing list about 5 years ago. We do not know the author personally, but the code looks good and has been thoroughly tested by us. I kept their Signed-off-by because I didn't want to falsely claim authorship.

Unless he answers to this mail, what would be the best way to proceed?

Should I keep him as the Author: in the git metadata but remove the pseudo-anonymous Signed-off-by, and instead add my own Signed-off-by (and perhaps a Co-developed-by or From: note) to certify the Developer's Certificate of Origin (DCO) myself?

Anyways this will likely be reworked based on the sahiko-bot recommendations to make regen not a regulator but a gpio that can be controlled by a separate regulator-fixed. This will also clarify/remove the "same meaning" statements and ambiguities.

Thanks and BR,
Nikolaus