Re: [PATCH 09/16] ASoC: dt-bindings: add OpenPandora Sound Card
From: H. Nikolaus Schaller
Date: Mon Jul 13 2026 - 08:03:31 EST
> Am 13.07.2026 um 11:42 schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>
> On 13/07/2026 11:38, H. Nikolaus Schaller wrote:
>>
>>
>>> Am 13.07.2026 um 11:21 schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>>>
>>> On 13/07/2026 10:27, H. Nikolaus Schaller wrote:
>>>> Hi Krzysztof,
>>>>
>>>> Thank you for the feedback.
>>>>
>>>>
>>>> It does not emit any C compiler issues or runtime problems so it remained unnoticed.
>>>
>>> I do not believe.
>>>
>>> There is a clear warning from Rob's bot.
>>>
>>> You just did not follow the process of building the code (compiler has
>>> nothing to do here). Read submitting patches in DT dir and then writing
>>> schema for further instructions. This is ABSOLUTE MINIMUM. We are not
>>> your build test service.
>>>
>>>>
>>>> It was notified by the sahiko-bot and will be fixed in v2.
>>>
>>> Sashiko has nothing to do with that.
>>>
>>> You DID NOT BUILD the code.
>>
>> Hm. You are confusing me. I did "make" and did not get any errors...
>> And the resulting code works as intended.
>
> 'make' alone does not build that, just like other pieces of code they
> have own - well documented and always expected - build processes.
>
> I don't know what is confusing in my message, since I pointed you to
> SPECIFIC guide telling you EXACTLY what to do (and which you did not do).
Confusing was the phrase "building the code". For my understanding
"building the code" is the process of building ("translating the code")
to get vmlinux or similar and a DTB and kernel modules.
As far as I understand the bindings they are used to check the DTS source
files against. So here is no translation of bindings into a real DTB that
finaly runs on a device. So I had assumed that schemas are "validated"
(not "built") by dt_binding_check.
This made me confused.
Back to topic:
It finally turned out that our script to run the required checks automatically
was no longer operational and silently ignored the validations. Therefore
nobody noticed before the bots did. Good to have a second and independent
check.
So sorry for the confusion we have introduced...
v2 will be checked as it previously was.
BR and thanks,
Nikolaus