Re: [PATCH] regcache: disable cache_only before rewriting paging registers
From: Mark Brown
Date: Mon Jul 13 2026 - 11:13:54 EST
On Mon, Jul 13, 2026 at 09:59:46PM +0700, Bui Duc Phuc wrote:
> However, after reviewing the existing users of regcache_sync(), I found
> that there are several drivers that call regcache_sync() without first calling
> regcache_cache_only(map, false). That made me think such a change
> could break existing users, so I decided not to pursue that approach.
> If the intended usage is indeed that regcache_cache_only(map, false) should
> always be set before regcache_sync() is ever used, then I'm happy to revisit
> this approach and also prepare follow-up patches for the drivers that don't
> currently follow that pattern.
You might not bother setting cache only in the suspend/resume path if
you know nothing else from the driver will touch the device until resume
is completed, something else might block anything that would try to
write.
Attachment:
signature.asc
Description: PGP signature