Re: [PATCH v3 v3] PCI: dwc: Add pci id for LECARC pcie pmu

[Bjorn Helgaas]

On Mon, Jul 13, 2026 at 10:10:13AM +0800, Braden Zhang wrote:
> From: Brett Zhou <brett_zhou@xxxxxxxxxxxxxxx>
> 
> This patch adds support for the PCIe PMU found
> on LECARC SoCs, which utilize the DesignWare PCIe Controller IP
> 
> Signed-off-by: Brett Zhou <brett_zhou@xxxxxxxxxxxxxxx>
> Reviewed-by: Bjorn Helgaas <helgaas@xxxxxxxxxx>

I gave you some comments but did not provide a "Reviewed-by" tag, so
including one here is not valid, see:

  https://lore.kernel.org/linux-pci/20260710172212.GA964796@bhelgaas/
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v7.1#n539

Also relevant:

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst?id=v7.1#n134

In this case, you could say something like:

  Add support for the PCIe PMU found on LECARC SoCs, which use the
  DesignWare PCIe Controller IP.

Wrap it to fill 75 columns.

In the subject line:

  s/pci/PCI/
  s/id/ID/
  s/pcie/PCIe/
  s/pmu/PMU/

since these are all initialisms, not ordinary English words.

> Signed-off-by: Braden Zhang <braden_zhang@xxxxxxxxxxxxxxx>
> ---
> Changes in v3:
> - Update: move definition to pcie-dwc.h a
> - Format: Update the subject line to follow the style of previous pcie-dwc.h changes.
> - Link to v2: https://patch.msgid.link/20260710-pcie-pmu-v2-1-a3d73d4d9051@xxxxxxxxxxxxxxx
> 
> Changes in v2:
> - Format: repalce space with tab to separate the macro name and the value.
> - Link to v1: https://patch.msgid.link/20260710-pcie-pmu-v1-1-1519e580313f@xxxxxxxxxxxxxxx
> 
> To: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> To: Jingoo Han <jingoohan1@xxxxxxxxx>
> To: Manivannan Sadhasivam <mani@xxxxxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  include/linux/pcie-dwc.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/pcie-dwc.h b/include/linux/pcie-dwc.h
> index 8ff778e7aec0..0df5fa81b561 100644
> --- a/include/linux/pcie-dwc.h
> +++ b/include/linux/pcie-dwc.h
> @@ -11,6 +11,8 @@
>  
>  #include <linux/pci_ids.h>
>  
> +#define PCI_VENDOR_ID_LECARC           0x0720
> +
>  struct dwc_pcie_vsec_id {
>  	u16 vendor_id;
>  	u16 vsec_id;
> @@ -32,6 +34,8 @@ static const struct dwc_pcie_vsec_id dwc_pcie_rasdes_vsec_ids[] = {
>  	  .vsec_id = 0x02, .vsec_rev = 0x4 },
>  	{ .vendor_id = PCI_VENDOR_ID_SAMSUNG,
>  	  .vsec_id = 0x02, .vsec_rev = 0x4 },
> +	{ .vendor_id = PCI_VENDOR_ID_LECARC,
> +	  .vsec_id = 0x02, .vsec_rev = 0x4 },
>  	{}
>  };
>  
> 
> ---
> base-commit: a635d6748234582ea287c5ffeae28b9b23f91c7e
> change-id: 20260710-pcie-pmu-5ef78c56c3b6
> 
> Best regards,
> --  
> Braden Zhang <braden_zhang@xxxxxxxxxxxxxxx>
>